-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Support Subdomains #69
Comments
Hi @Zeeex Thank you for the suggestions. Support for both subdomains and wildcards definitely sounds nice, and I am keen on adding them both. Let's see what would be the best way to approach. Blocking subdomainsBecause wildcard in DNS does not cover root domain, *.fandom.com would block only subdomains, but not fandom.com. To block them both, both would need to be stated:
I think this is the control you were referring to. No hidden behaviour as well. To block only subdomains:
And to block all subdomains except one:
Can we agree this is the behaviour we would want? Wildcards supportBesides blocking subdomains, wildcard could be used anywhere in the path, to match any directory for example. The following example would block all topics:
And similarly, to block all topics except one:
Can we agree this is the behaviour we would want? |
Absolutely, both blocking subdomains and wildcard support are fantastic additions! Excellent examples as well. I'm eagerly anticipating this implementation. |
Hi again @Zeeex I have it implemented. Also added support for matching any one character using Note: Please, feel free to check out #70. The most important file to look at, is |
Hello, this extension is working great, thanks for that, and I was thinking it can be improved even more.
Currently we can only block full URL and domains in general, but option to block (include) subdomains is not available.
Scenario: Let's say I want to block all URLs from one domain, and all subdomains that come from it.
Example URL: "https://onepunchman.fandom.com"
I can only block "fandom.com", and it works fine on that specific site, but it doesn't block any subpages.
*.fandom.com
But i'd prefer option 1, because it gives us the control to choose.
The text was updated successfully, but these errors were encountered: