Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to build with private stuff? #1

Closed
grandpaul opened this issue Oct 23, 2013 · 1 comment
Closed

Do we need to build with private stuff? #1

grandpaul opened this issue Oct 23, 2013 · 1 comment
Assignees

Comments

@grandpaul
Copy link

Hi,

While reading the code, I found that actually we don't need to depends on the private stuff which tightly binds to a specific Qt version?

I applied this patch and it still works good.
Please check if we really need to include the private stuff?

diff --git a/Shell/main.cpp b/Shell/main.cpp
index 133e564..e800415 100644
--- a/Shell/main.cpp
+++ b/Shell/main.cpp
@@ -1,7 +1,5 @@
 #include <QtQuick/QQuickView>
 #include <QtGui/QGuiApplication>
-#include "private/qquickwebview_p.h"
-#include "private/qquickflickable_p.h"

 int main(int argc, char *argv[])
 {
diff --git a/Shell/shell.pro b/Shell/shell.pro
index bf51e34..f7fec5c 100644
--- a/Shell/shell.pro
+++ b/Shell/shell.pro
@@ -1,4 +1,4 @@
-QT += qml quick quick quick-private webkit webkit-private
+QT += qml quick quick webkit

 #mac:CONFIG -= app_bundle

@penk
Copy link
Owner

penk commented Nov 19, 2013

Found that was needed on Qt5.0.2/Mac OSX 10.8.5, will check again when Qt 5.2 being released.

@ghost ghost assigned penk Nov 19, 2013
@penk penk closed this as completed in 47252ec Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants