segfault after https://example.com/accounts/saml/example/acs/ #3593
Comments
|
Nevermind, this is fixed here 0c49379 |
|
sorry the issue still remains with code that is in main. The segfault happens here: The exception never is handled as it sefaults. My guess it happens inside of the OneLogin_Saml2_Auth https://github.com/SAML-Toolkits/python3-saml/blob/master/src/onelogin/saml2/auth.py which is a different project. |
That is only about requiring POST requests -- it is unlikely that it fixes your issue as your scenario involves POST.
A segfault really points to an issue elsewhere, as allauth itself, being pure python code, typically does not cause segfaults. So this needs to be fixed upstream. Having said that, if there are any workarounds that can be put in place to avoid the segfault, let me know... but other than that this really is not actionable on this end. |
|
There are a few mentions of segfaults here: https://github.com/search?q=repo%3ASAML-Toolkits%2Fpython3-saml+segfault&type=issues |
|
Can you try downgrading lxml as is mentioned here? SAML-Toolkits/python3-saml#389 |
|
Use |
|
We are also getting the same segfault error (Process finished with exit code 245). The segfault happens in the same Installed lxml and xmlsec both from source. But, the issue still persists. It happens on about 30-40% of the POST requests. Rest of the time the intergration works as expected. error log |
|
Can you capture one of the POST requests that causes the segfault and turn it into a small example project demonstrating the issue? |
|
sure @pennersr, let me create a small example project to replicate this issue. |
|
Hi @pennersr , I have create a sample project at https://github.com/vinodpandey/saml-allauth-demo. Below are the steps to replicate the issues:
I have uploaded video at https://youtu.be/NV2FokoH1zI which shows the above repository setup steps and replicates the segfault issue. In above same project, I ran below commands and tested it again. But, even after that, the issue occurs after 4-5 tries. |
|
For me, the crash does not reproduce. Though, I am running nix with: And relevant Can you check what version of |
|
My software versions in Mac are below
I created a docker image with It seems the issue is limited to Macbook M2 only. I am debugging the issue and will update if I find the root cause/fix for this. |
|
Good news (?), I am lucky enough to also have an M2 mac, and I was able to reproduce the crash with the demo provided by @vinodpandey I believe the problem is again caused by mismatches in version of I too have Reinstalling Assuming you already worked around that to get |
|
@nosnilmot I uninstalled both I found a workaround for fixing the crashes in Mac M2. You are correct, the issue is occuring because of version mismatch only. After running Below is my analysis regarding In my Mac M2, it has it's own version of When using When using Now, after running the tests again, the crash still occurs. I upgraded lxml In Ubuntu 20.04, if I upgrade I couldn't find a way to make I tried below commands, but that resulted in mismatched LIBXML_VERSION and LIBXML_COMPILED_VERSION. The crashes continued to occur after that. |
|
It is important that all components (
Both I do not know why your I can force same result as you only if I override I believe this is a reliable way to get working
|
|
Thanks @nosnilmot for helping to debug the issue. I re-installed homebrew and rechecked the steps above. I was still getting the same mismatched etree.LIBXML_VERSION and etree.LIBXML_COMPILED_VERSION. I debugged futher and found that the commands are behaving differently with different versions of python. I am using Although, In In Python 3.10.12, executing the same command gives mismatched version of LIBXML_VERSION and LIBXML_COMPILED_VERSION. |
|
You still have something odd in your system configuration. I have no idea why it only shows up for python 3.10.12 for you - maybe that's installed differently? (current brew 3.10 is 3.10.13) |
|
I am using https://github.com/pyenv/pyenv for installing multiple python versions. Both I have not set the |
|
I cannot reproduce. Perhaps reinstall ( |
|
I used Mac Migration Assistant software to migrate from Macbook Pro x86 to Macbook M2. This might be the reason why my setup is working weirdly as the architecture changed from x86 to ARM. Below is my output after |
|
I think you forgot to set |
|
Thanks a lot @nosnilmot. It's working correctly for me. I can sleep better now 😄. Below is the combination that worked for me. Without LDFLAGS and CPPFLAGS I was still getting the mismatched version. |
|
python3-saml depends on xmlsec and lxml. Because xmlsec also depends on lxml, this feels like a problem that xmlsec should resolve. It seems that there is some activity on the xmlsec repo toward this: xmlsec/python-xmlsec#283, though it's not clear whether xmlsec is maintained well enough to address this or whether it will need to be forked. |
|
This is not an allauth issue, but I also needed the
Then, |
|
Looks like xmlsec 1.3.14 addressed this issue! |
Will try to validate this, thanks for the heads-up, @vdboor |
Getting a weird segfault after https://example.com/accounts/saml/example/acs/ is POST.
Looking at the SAML-tracer (chrome extension) everything looks good, as expected. My guess is that one of the dependencies like libxmlsec1... Not really sure. I am having a hard time figuring how what is segfault-ing. Can't run on my local machine as I don't have a SSO config for that to debug.
The text was updated successfully, but these errors were encountered: