Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading Files #1

Closed
ghost opened this issue Jul 20, 2013 · 15 comments
Closed

Downloading Files #1

ghost opened this issue Jul 20, 2013 · 15 comments

Comments

@ghost
Copy link

ghost commented Jul 20, 2013

Users are not able to download uploaded files.

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

I think this is due to the uploads folder not being committed because it was empty. Try creating a folder called uploads in the root of the project

@ghost
Copy link
Author

ghost commented Jul 20, 2013

I ran into a new issue where the browser can not display images, or load PDFs.
screen shot 2013-07-19 at 11 20 39 pm
screen shot 2013-07-19 at 11 20 52 pm

4ndr3w added a commit that referenced this issue Jul 20, 2013
@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

I built this feature on my netbook which was running windows. Some stuff didn't run right under *nix.
The content of any document you uploaded was the string "undefined", so that's why stuff appeared corrupt for you.

This should be fixed now

@ghost
Copy link
Author

ghost commented Jul 20, 2013

I am still running into these errors, here is the log
screen shot 2013-07-19 at 11 35 34 pm

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

What is inside the file if you try to open it from finder?

@ghost
Copy link
Author

ghost commented Jul 20, 2013

When opened with Finder:
screen shot 2013-07-20 at 12 00 28 am
And as plain text:
screen shot 2013-07-20 at 12 01 39 am

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

So it contains image like binary stuff but it's corrupt?

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

Is the file at the tmp location in the debug output corrupt too?

@ghost
Copy link
Author

ghost commented Jul 20, 2013

I guess so. PDFs can open, but with no content inside:
screen shot 2013-07-20 at 12 04 19 am

@ghost
Copy link
Author

ghost commented Jul 20, 2013

How can I check that?

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

In your screenshot, the object has a path property. Its like /tmp/g34gg5g4gh45t435g34g
open that and see if it works

Basically what the server does is open the tmp file that got uploaded and resave it into the uploads folder

@ghost
Copy link
Author

ghost commented Jul 20, 2013

That loaded fine
screen shot 2013-07-20 at 12 10 47 am

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

Something probably gets butchered when it coverts it to a string, i'll have a fix in a few secs

@4ndr3w
Copy link
Contributor

4ndr3w commented Jul 20, 2013

Commit pushed

@ghost
Copy link
Author

ghost commented Jul 20, 2013

That did the trick!

@ghost ghost closed this as completed Jul 20, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant