Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Add instruction on using CLI in windows prompt #11

Closed
TheWindRider opened this issue Nov 9, 2017 · 5 comments
Closed

Add instruction on using CLI in windows prompt #11

TheWindRider opened this issue Nov 9, 2017 · 5 comments

Comments

@TheWindRider
Copy link
Contributor

The example script in the Data Validation CLI section needs a little adaptation to work in windows prompt, otherwise double quotes won't be recognized and error will be reported as screenshot at bottom.

I may contribute an easy solution for windows to the README, but I don't know how to apply font color to output message in windows prompt.

validate_cli

@ghost
Copy link

ghost commented Nov 9, 2017

Your issue doesn't follow our guidelines. Please fix the following:

  • Issue must have at least one label (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@TheWindRider
Copy link
Contributor Author

@gitmagic-bot Looks like I don't have permission to add labels?

@jasonwalsh
Copy link
Contributor

Hi @TheWindRider, thanks for reporting this. I think updating the README is a good idea.

As for coloring terminal output, I'm currently using the TermColors class. However, I think the __main__ module could be cleaned up a bit. I also found the termcolor module on PyPI and think it might be a better solution than using the TermColors class.

Any thoughts?

@TheWindRider
Copy link
Contributor Author

Ok I will work on the README. @rightlag Would you prefer a new pair of screenshots, or more low-key modification like one line of example code that works in windows terminal?

I don't have good knowledge about the PyPI unfortunately.

@jasonwalsh
Copy link
Contributor

Just adding the Windows command should be fine. Could you also add headers above the commands (e.g.):

macOS

$ command

Windows

> command

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants