Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing values to larva-tokens #186

Closed
laras126 opened this issue Apr 16, 2020 · 3 comments
Closed

Add spacing values to larva-tokens #186

laras126 opened this issue Apr 16, 2020 · 3 comments
Labels
addition New feature or request

Comments

@laras126
Copy link
Contributor

The designers are adding a spacing scale to their style guide. We need to have corresponding tokens for those values that can be configured in larva-tokens and output to the styleguide.

I proposed keeping the naming the same for the token-based values:

  • spacer-025
  • spacer-050
  • spacer-075
  • spacer-1
  • spacer-125
  • spacer-150
  • spacer-175
  • spacer-2
@laras126 laras126 added the addition New feature or request label Apr 16, 2020
@asannad
Copy link
Member

asannad commented Apr 16, 2020

Can we make em consistent like spacer-1 should be spacer-100?

@curtisbelt
Copy link
Contributor

If implemented, Tailwind would supersede this issue - see #187

@laras126
Copy link
Contributor Author

This was added in PR #202 - @asannad that is a good suggestion and I wish I saw this before I did it :( That said, there will be a push in the future to update existing utilities and that will be a good time to make naming improvements. I created issue #248 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laras126 @asannad @curtisbelt