Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class naming inconsistent #12

Closed
jimr opened this issue Jul 23, 2014 · 1 comment
Closed

Class naming inconsistent #12

jimr opened this issue Jul 23, 2014 · 1 comment

Comments

@jimr
Copy link

jimr commented Jul 23, 2014

For example, Highcharts versus Highchart versus HighCharts (the first is correct as per their website), and the use of the Base prefix. I would propose something like this:

  • HighChartsView -> HighchartsView
  • BaseColumnsHighChartsView -> HighchartsColumnView
  • HighchartPlotLineChartView -> HighchartsLineView
  • HighChartPieView -> HighchartsPieView
  • HighChartDonutView -> HighchartsDonutView

Additionally, BaseLineChartView isn't subclassed by anything - should it be (maybe HighchartPlotLineChartView)?
@jimr jimr mentioned this issue Jul 23, 2014
Closed
@Natim
Copy link
Collaborator

Natim commented Jan 17, 2020

@jimr would you like to fix this?

@Natim Natim closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimr @Natim