Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for mandatory context before calling get_context_data #64

Open
bhrutledge opened this issue Aug 18, 2016 · 2 comments
Open

Check for mandatory context before calling get_context_data #64

bhrutledge opened this issue Aug 18, 2016 · 2 comments

Comments

@bhrutledge
Copy link
Contributor

In BaseMail.__init__, I think it would be helpful to validate context against self.get_params (and raise MissingMailContextParamException) before doing anything else. That way, self.get_context_data could safely reference the required params while adding additional context.

But, maybe there's some element of the flow that I'm missing...

@Natim
Copy link
Collaborator

Natim commented Aug 18, 2016

@bhrutledge You are probably correct, do you mind working on a PR to fix that? I will be happy to review it and help.

@bhrutledge
Copy link
Contributor Author

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants