Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #88 Fix contrib app for django 2.1 #89

Closed
wants to merge 3 commits into from
Closed

Refs #88 Fix contrib app for django 2.1 #89

wants to merge 3 commits into from

Conversation

hsmett
Copy link
Contributor

@hsmett hsmett commented Mar 20, 2019

  • Fix mail_factory.contrib app for django >= 2.1
  • Isort the code
  • Display python warnings while running tox targets
  • Remove some Django < 1.11 compatibility code

Fix #88

@hsmett hsmett self-assigned this Mar 20, 2019
k4nar
k4nar approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .

@joehybird joehybird mentioned this pull request Jan 27, 2020
Merged
@DainDwarf
Copy link
Contributor

Done in the rebase #91

@DainDwarf DainDwarf closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k4nar k4nar k4nar approved these changes

Assignees

@hsmett hsmett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

django.contrib.auth.views.password_reset RemovedInDjango21Warning
3 participants
@hsmett @DainDwarf @k4nar