update China Labour Day 2019 based on latest official notification. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobord
requested changes
Apr 12, 2019
There was a problem hiding this comment.
Thanks a lot for your contribution. I'm definitely sorry that I couldn't add it earlier, things have been pretty busy.
Although, better late than never, I think that this patch should belong to workalendar. Although in order to be accepted, it'll have to be tested. Could you please add the tests related to this new holidays?
|
No problem. Wrong holiday shift fixed and all tests passed. Full coverage over related new holidays and workdays. |
2 tasks
|
closing in favor of #347 - there's no changelog in your PR ; but you'll be mentioned in the contributors |
Merged
|
Sorry for the delay. The fix has been merged and released here: https://pypi.org/project/workalendar/4.3.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update China Labour Day holiday plans of 2019 based on latest official notification. The government officially changed the holiday plan in March 22, 2019.