Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8speaks reports both W503 and W504 #103

Closed
kohr-h opened this issue Feb 4, 2019 · 3 comments
Closed

pep8speaks reports both W503 and W504 #103

kohr-h opened this issue Feb 4, 2019 · 3 comments

Comments

@kohr-h
Copy link

kohr-h commented Feb 4, 2019

Apparently there has been a recent change in pycodestyle that favors line breaks before binary operators over breaks after them:

# Old style
x = (123545925240502 +
     74979743 *
     8383)
# New style
x = (123545925240502
     + 74979743
     * 8383)

Currently, pep8speaks complains about both variants: the first one triggers W504, the second one W503.

In principle, W504 should be ignored by default in pycodestyle, but that doesn't seem to be the case.

Should one of the two go into the list of default ignores?

@OrkoHunter
Copy link
Collaborator

Hi @kohr-h!

Can you let me know about the version of pycodestyle with this change? As soon as it gets published on pypi, I can deploy the latest version.

pep8speaks does not have any default pycodestyle configuration. I recommend using .pep8speaks.yml to configure pycodestyle according to your needs.

@kohr-h
Copy link
Author

kohr-h commented Feb 5, 2019

@OrkoHunter I'm not entirely sure. The changelog mentions W504 as a new check in version 2.4.0 (released 2018-04-10), but at the same time writes "This check is ignored by default." Still, pep8speaks started emitting W504 a while ago (end of 2018 maybe?), and it's hard to avoid both warnings at the same time :-)

With default configuration, I meant the config of pep8speaks itself, which I guess people take as template?

@OrkoHunter
Copy link
Collaborator

Oh! Sure, it makes sense to me.

I will add W504 in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants