Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8speaks only returns W292 codes even when not relevant or ignored #165

Closed
Eskapp opened this issue Apr 15, 2020 · 3 comments
Closed

pep8speaks only returns W292 codes even when not relevant or ignored #165

Eskapp opened this issue Apr 15, 2020 · 3 comments

Comments

@Eskapp
Copy link

Eskapp commented Apr 15, 2020

Context:
I went back working on a private project for which we have a fork of pep8speaks as a webhook (done as suggested in https://github.com/OrkoHunter/pep8speaks/wiki/Instructions-to-deploy-a-fork)

Things were working perfectly by the end of 2018 as this screenshot proves:
sc1

Coming back working on this project, pep8speaks now only sees W292 issues which are non-existent (not reported when everything was working fine). I created a commit adding one empty line in the middle of a file and this is the output:
sc2

It basically lists all the files that have been modified and returns W292 for each one of them.

I have been playing around with the .pep8speaks.yml file for hours now. I have this behavior on all repositories to which I add the webhook.

.pep8speaks.yml file that I have:

# File : .pep8speaks.yml

scanner:
    diff_only: False  # If True, errors caused by only the patch are shown

pycodestyle:
    max-line-length: 120
    ignore:  # Errors and warnings to ignore
        - E741,  # do not use variables named 'l', 'O', or 'I'
        - E122,  # continuation line missing indentation or outdented
        - E127,  # continuation line over-indented for visual indent
        - E128,  # continuation line under-indented for visual indent
        - W503,  # line break occurred before a binary operator
        - E402,  # module level import not at top of file

Among the things that I've tried without success:

  • Removing the commas
  • Adding W292 to the ignore section
  • Specifying the linter as flake8 or pycodestyle
    The result is the same every time, W292 is returned for all the modified files. I am clueless as the next step to take to get this working as it was before.
@OrkoHunter
Copy link
Collaborator

This reminds me of #161 All the issues were only E111.

Screen Shot 2020-04-16 at 10 07 53

@Eskapp
Copy link
Author

Eskapp commented Apr 16, 2020

We decided to retake all the steps from scratch.
Now we get a ModuleNotFoundError: No module named 'werkzeug.contrib' when starting the heroku server. We use the most recent version of master.

Full log:

2020-04-16T18:25:34.538233+00:00 app[web.1]: [2020-04-16 18:25:34 +0000] [11] [ERROR] Exception in worker process
2020-04-16T18:25:34.538235+00:00 app[web.1]: Traceback (most recent call last):
2020-04-16T18:25:34.538236+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/arbiter.py", line 557, in spawn_worker
2020-04-16T18:25:34.538237+00:00 app[web.1]: worker.init_process()
2020-04-16T18:25:34.538237+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/workers/base.py", line 126, in init_process
2020-04-16T18:25:34.538238+00:00 app[web.1]: self.load_wsgi()
2020-04-16T18:25:34.538238+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/workers/base.py", line 136, in load_wsgi
2020-04-16T18:25:34.538239+00:00 app[web.1]: self.wsgi = self.app.wsgi()
2020-04-16T18:25:34.538240+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/app/base.py", line 67, in wsgi
2020-04-16T18:25:34.538240+00:00 app[web.1]: self.callable = self.load()
2020-04-16T18:25:34.538241+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/app/wsgiapp.py", line 65, in load
2020-04-16T18:25:34.538241+00:00 app[web.1]: return self.load_wsgiapp()
2020-04-16T18:25:34.538242+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/app/wsgiapp.py", line 52, in load_wsgiapp
2020-04-16T18:25:34.538242+00:00 app[web.1]: return util.import_app(self.app_uri)
2020-04-16T18:25:34.538243+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/util.py", line 357, in import_app
2020-04-16T18:25:34.538243+00:00 app[web.1]: __import__(module)
2020-04-16T18:25:34.538243+00:00 app[web.1]: File "/app/server.py", line 55, in <module>
2020-04-16T18:25:34.538244+00:00 app[web.1]: app = create_app()
2020-04-16T18:25:34.538244+00:00 app[web.1]: File "/app/server.py", line 50, in create_app
2020-04-16T18:25:34.538244+00:00 app[web.1]: sess.init_app(app)
2020-04-16T18:25:34.538245+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/flask_session/__init__.py", line 61, in init_app
2020-04-16T18:25:34.538246+00:00 app[web.1]: app.session_interface = self._get_interface(app)
2020-04-16T18:25:34.538246+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/flask_session/__init__.py", line 93, in _get_interface
2020-04-16T18:25:34.538246+00:00 app[web.1]: config['SESSION_USE_SIGNER'], config['SESSION_PERMANENT'])
2020-04-16T18:25:34.538247+00:00 app[web.1]: File "/app/.heroku/python/lib/python3.7/site-packages/flask_session/sessions.py", line 313, in __init__
2020-04-16T18:25:34.538247+00:00 app[web.1]: from werkzeug.contrib.cache import FileSystemCache
2020-04-16T18:25:34.538248+00:00 app[web.1]: ModuleNotFoundError: No module named 'werkzeug.contrib'
2020-04-16T18:25:34.538647+00:00 app[web.1]: [2020-04-16 18:25:34 +0000] [11] [INFO] Worker exiting (pid: 11)
2020-04-16T18:25:34.787117+00:00 heroku[web.1]: State changed from starting to crashed

@OrkoHunter I hope that will help...

@OrkoHunter
Copy link
Collaborator

Thanks @Eskapp ! This is a known issue with a dependency which is sadly breaking our master build :(
#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants