Exclude option is ignored

[daviddavis]

It looks like the exclude option in .pep8speaks.yml is being ignored.

I have an example repository set up:

https://github.com/daviddavis/pep8speaks-exclude

You can see that I am excluding the docs directory:

https://github.com/daviddavis/pep8speaks-exclude/blob/master/.pep8speaks.yml#L7

However, on PRs, pep8speaks still shows errors for files in the excluded directory:

daviddavis/pep8speaks-exclude#2

Running pycodestyle locally with --exclude works:

$ pycodestyle --max-line-length 100 .
./docs/conf.py:1:1: E265 block comment should start with '# '
./docs/conf.py:3:1: E265 block comment should start with '# '
$ pycodestyle --max-line-length 100 --exclude docs .
$

Not sure if I doing something wrong? I also tried a string instead of an array (ie exclude: docs) but that didn't work either.

[daviddavis]

It looks like the problem is that pep8speaks is just running pycodestyle on a file file_to_check.py so excludes never matches anything. We need to filter the files before this point. Opening a PR #53.

[OrkoHunter]

Hi @daviddavis !

It looks like filename_match needed more tweaks than the fnmatch. I have added them in this commit. Can you please verify it?

[daviddavis]

@OrkoHunter looks good and works well! 👍

Thank you!