Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account sharing support #4

Closed
pepeien opened this issue Jun 30, 2024 · 2 comments
Closed

Account sharing support #4

pepeien opened this issue Jun 30, 2024 · 2 comments
Assignees
@pepeien
Labels
enhancement New feature or request

Comments

@pepeien
Copy link
Owner

pepeien commented Jun 30, 2024 •
edited
Loading

Creating the same account, even trying to match the colors or remembering the specifications is a hassle. Account sharing is real and not uncommon, this application should support that.
@pepeien pepeien added the enhancement New feature or request label Jun 30, 2024
@pepeien pepeien self-assigned this Jun 30, 2024
@pepeien
Copy link
Owner Author

pepeien commented Jun 30, 2024

In order to implement this a few changes to the current data structure are needed:

  1. Accounts should be able to differentiate its owner and shared users;
    • This will block users from modifying the Account;
    • It will reduce the amount of changes to the overall code.
  2. Purchases should hold the userId since accounts aren't unique keys anymore.

@pepeien pepeien mentioned this issue Jul 3, 2024
Merged
3 tasks
@pepeien
Copy link
Owner Author

pepeien commented Jul 3, 2024

Fixed at #5

@pepeien pepeien closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepeien pepeien

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pepeien