Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone not being used? #13

Closed
worldlyjohn opened this issue Mar 18, 2017 · 3 comments
Closed

timezone not being used? #13

worldlyjohn opened this issue Mar 18, 2017 · 3 comments

Comments

@worldlyjohn
Copy link

First, this is very helpful -- thanks for putting it out!

My server is in UTC, so I'm passing custom timezone to Scheduler as "America/New_York" but it's not taking. Not affected by every()->hour('00') calls but every()->day('9:30') is.

any ideas?

@peppeocchi
Copy link
Owner

@worldlyjohn that's a documented feature that never got implemented (probably on some local branch in the early stages).

I am currently working on a v2 of this project and I don't think I'll implement the feature to execute jobs based on a custom timezone. I haven't found a clean way of doing that (could be the reason I didn't implemented it)

The change I already made on v2 is to use the server timezone instead of a default value (current default is Europe/Dublin).

I'll make the same change on the current version, that should fix the issue you're having now (you won't need to specify a timezone, the scheduler will use the server timezone).

Of course if you can find a clean way of implementing that feature, a PR would be much appreciated.

@peppeocchi
Copy link
Owner

@worldlyjohn v2 uses the server timezone, if you wish to update to this version make sure to read the changelog and to adjust your scheduler file as needed.

@worldlyjohn
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants