Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint issues #9

Closed
frli4797 opened this issue Apr 12, 2019 · 4 comments
Closed

eslint issues #9

frli4797 opened this issue Apr 12, 2019 · 4 comments

Comments

@frli4797
Copy link
Contributor

Found a few minor things with eslint. Like unused imports and vars, double quotes, indents and similar stuff.

PR or leave?
@perbrage
Copy link
Owner

A PR those things would be welcomed. Just make sure you have the latest code I pushed today that resolved the info, status and locks issues. I also upgraded a few third library packages for security purposes.

@frli4797
Copy link
Contributor Author

I'll push the eslint config as well. You can chose to have it in .gitignore as you please.

@perbrage
Copy link
Owner

Hi,

Seems I did not pull this one. Can you check with the latest code if there are any conflicts?

@perbrage
Copy link
Owner

perbrage commented Jan 9, 2020

I closed the pull request for these issues, cause there were conflicts after doing to much on my end. If you feel you want to try again, go ahead. But I am adding new features in the near future as well, so you might want to wait a bit.

Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@perbrage @frli4797