Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

online viewer: descrambled #104

Open
prcvlusr opened this issue May 8, 2019 · 2 comments
Open

online viewer: descrambled #104

prcvlusr opened this issue May 8, 2019 · 2 comments

Comments

@prcvlusr
Copy link
Collaborator

prcvlusr commented May 8, 2019

the online viewer as today shows scrambled images
attached here are the online viewer files to show descrambled images (crs only); tested up to ~1 image shown per sec

  • it would be useful for user to be able to see descrambled images
  • There maybe is a better way (plugin or whatnot) to include the descrambling rather than editing the file as I did. if so, how?
  • at the present moment a single 2Dimage is shown
    which modification would be necessary instead to show/refresh a (3x1) subplot of 2D images?
    (apart from the obvious "use plt.subplot")

online_viewer_descrambled.zip

@benjaminboitrelle
Copy link

Dear Percivallians,

I have updated the Online Viewer to be able to plot 3 subplots of Coarse/Fine/Gain
I have modified:

  • descrambler.py file (renamed from Alessandro APy..): return a tuple of coarse/fine/gain descrambled
  • mplplot.py: add a multi_render_frame method which is basically calling render_frame 3 times. The script has been modified to plot 3 subplots(13*)
  • Live_viewer: call multi_render_frame instead of render_frame

I do not know on which folder I can fork my files. Below is a link to my GitHub. Please let me know on which folder it should be.

https://github.com/benjaminboitrelle/live_viewer/tree/live_viewer

Regards,

Benjamin

@ajgdls
Copy link
Contributor

ajgdls commented Nov 11, 2019

Hi @benjaminboitrelle , assuming the live view code does not actually depend on percivalui at all, then actually I would probably add it to the percival-detector repository as a python tool. It is used as a standalone application to view data coming out of the DAQ pipeline and so that repository would be the final destination for it anyway (percivalui will eventually end up in that repo).

You can add the files to a directory called:

percival-detector/tools/python

in your own fork and then PR to the percival-detector repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants