-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capturing a selector instead of a page? #71
Comments
Related percy/percy-cypress#56 |
@djones happy to see I'm not the only one taking this route :D. What can I do? I Could see this working as key/value pairs maybe? percySnapshot(page, 'buttons', {
elements: {
containedButtons: '.buttons.contained',
outlineButtons: '.buttons.outline',
}
}); |
Left a comment on a related issue: percy/percy-cypress#56 (comment)
|
Hey folks!
We're evaluating how to best do Visual Regression tests for a range of problems. The first thing we're trying to tackle is our design system. Now, we don't want to use Storybook (we're using docz), but I thought I would be able to relatively easily use puppeteer to create snapshots of marked elements on our page. I have everything working so far, except I don't have a way to target sub-elements on a page instead of the whole page (the
percySnapshot
function takes apage
as argument, which won't even run because typescript fails the test). Is this something you could help me with? I haven't dug into either puppeteer or these bindings enough yet, but think I could contribute it. I guess my first question would be; is this an option, an extra argument / overload, or an entirely new method?Thanks!
The text was updated successfully, but these errors were encountered: