Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReporterInterface does not include the methods added by HasEventEmitterTrait #207

Open
ezzatron opened this issue Jan 19, 2017 · 0 comments
Labels

Comments

@ezzatron
Copy link
Contributor

Currently in some parts of the code, such as the new composite reporter, we assume that a reporter will have the setEventEmitter() method, which comes from HasEventEmitterTrait that we add in AbstractTest:

        array_map(function (ReporterInterface $reporter) use ($eventEmitter) {
            $reporter->setEventEmitter($eventEmitter);
        }, $this->reporters);

There's been some other related stuff where we typehint on abstract classes when we should really use an interface instead. I think we need to audit our typehints, and interfaces.

@ezzatron ezzatron added the bug label Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant