Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test alias for it #210

Merged
merged 1 commit into from Feb 22, 2018
Merged

Conversation

ragboyjr
Copy link
Contributor

@ragboyjr ragboyjr commented Feb 11, 2018

This adds the test alias for it and the other variants. This is similar to facebook's Jest. I think there are some cases where test can be more suiting fo the test description.

Specifically, I've created a package which generates markdown documentation from your specs, and I've found that using it can make the wording weird, but test is more natural.

Btw, thank you so much for making this package, it's such a great tool!

Signed-off-by: RJ Garcia rj@bighead.net

Signed-off-by: RJ Garcia <rj@bighead.net>
@codecov-io
Copy link

codecov-io commented Feb 11, 2018

Codecov Report

Merging #210 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
- Coverage   97.67%   97.31%   -0.37%     
==========================================
  Files          22       22              
  Lines         905      781     -124     
==========================================
- Hits          884      760     -124     
  Misses         21       21
Impacted Files Coverage Δ
src/Console/Application.php 61.11% <0%> (-3.89%) ⬇️
src/Console/InputDefinition.php 100% <0%> (ø) ⬆️
src/Reporter/CompositeReporter.php 100% <0%> (ø) ⬆️
src/Core/Test.php 100% <0%> (ø) ⬆️
src/Runner/Context.php 100% <0%> (ø) ⬆️
src/Runner/Runner.php 100% <0%> (ø) ⬆️
src/Test/ItWasRun.php 100% <0%> (ø) ⬆️
src/Runner/SuiteLoader.php 100% <0%> (ø) ⬆️
src/Reporter/AnonymousReporter.php 100% <0%> (ø) ⬆️
src/Configuration.php 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e785c17...236ed93. Read the comment docs.

@brianium
Copy link
Member

Wow! Very cool on all fronts. I should probably get around to updating the README - but peridot is no longer actively maintained. I think kahlan has become the defacto tool for this style of testing. Hopefully is extensible enough to port your work over without too much effort.

@ragboyjr
Copy link
Contributor Author

Ah, that breaks my heart a little bit, I LOVE peridot and Leo, I’ll check out Kahlan though...

@ragboyjr
Copy link
Contributor Author

Hmm, I feel like Kahlan almost does too much. I love the simplicity of peridot, and I definitely don’t like their monkey patching. It encourages bad code if you need that much flexibility.

Any chance I could help out with maintaining peridot?

@brianium
Copy link
Member

I'm glad you have found it useful 😄- I would certainly be open to bringing on a new maintainer. Just to be transparent, I really don't have time/motivation myself to contribute to peridot anymore - so the project would need a new lead entirely. I definitely be up for answering questions and the like to make that transition smooth though.

I'm pretty proud of peridot and I think it is a great tool - I just don't do much in the way of PHP these days.

@ragboyjr
Copy link
Contributor Author

I’m up for it. I have a lot of vested interest in peridot. I use it a ton in my libraries and work. In addition, for platesphp v4 I rewrote all to peridot. Do you want to continue this discussion over email?

@brianium
Copy link
Member

Sounds good :) - I have my email address listed on my profile.

@ragboyjr ragboyjr merged commit 7574f8c into peridot-php:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants