Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection contributors being saved with empty strings #90

Closed
atomrab opened this issue Sep 4, 2015 · 4 comments
Closed

Collection contributors being saved with empty strings #90

atomrab opened this issue Sep 4, 2015 · 4 comments

Comments

@atomrab
Copy link

atomrab commented Sep 4, 2015

In Chrome, at least, the Editorial Note header in the collection view is large, indented, and not separated from the last citation field by a space, so that it appears to encroach on the "Contributors" data field (especially when the latter is blank). It should be left-justified, separated by a line break or paragraph space from the citation fields, and probably reduced in size (though I think it's fine if it stays a little larger than the other field names).

@atomrab
Copy link
Author

atomrab commented Sep 5, 2015

Update: I notice that this isn't a problem with local databases, since the edit collection/add period buttons separate the editorial note from the citation information. It's only a problem when viewing the canonical dataset, where those buttons do not appear.

@ptgolden ptgolden modified the milestone: CNI Nov 15, 2015
@ptgolden
Copy link
Member

Cosmetically fixed by 7bb3d6f

The problem was that there are contributors being saved with empty strings. Still gotta address that.

@ptgolden ptgolden removed this from the CNI milestone Apr 8, 2016
@rybesh rybesh changed the title Editorial note header (cosmetic) Collection contributors being saved with empty strings May 12, 2017
@rybesh
Copy link
Member

rybesh commented May 12, 2017

Updated description to reflect new focus.

@ptgolden
Copy link
Member

Fixed in bb457b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants