Don't accumulate intermediate messages passed to a callback.

perl-ldap · Sep 4, 2012 · 6144910 · 6144910
1 parent a1155cd
commit 6144910
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/Net/LDAP/Message.pm b/lib/Net/LDAP/Message.pm
@@ -148,10 +148,11 @@ sub decode { # $self, $pdu, $control
 
     my $intermediate = Net::LDAP::Intermediate->from_asn($data);
 
-    push(@{$self->{'intermediate'} ||= []}, $intermediate);
+    if (defined $self->{callback}) {
-
+      $self->{callback}->($self, $intermediate)
-    $self->{callback}->($self, $intermediate)
+    } else {
-      if (defined $self->{callback});
+      push(@{$self->{'intermediate'} ||= []}, $intermediate);
+    }
 
     return $self;
   } else {