Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to fail with explicit error messages when required attribute… #125

Closed
wants to merge 1 commit into from

Conversation

kjpye
Copy link

@kjpye kjpye commented Jul 16, 2018

…s are missing for new

connections and statement handles.

These are probably never used by end users, but explicit messages never hurt.

…s are missing for new

connections and statement handles.

These are probably never used by end users, but explicit messages never hurt.
@JJ
Copy link
Contributor

JJ commented Aug 10, 2018

There seems to be several errors with the latest 2018.06 version of Perl. Can you please check? https://travis-ci.org/perl6/DBIish/jobs/414423720

@JJ JJ requested a review from salortiz August 10, 2018 10:04
@salortiz
Copy link
Contributor

@JJ

This request to add logic that, at first, was implemented by the original required trait.
So, in my local copy I simply reverted your commit 399447b. All test passed:

[sog@monica DBIish]$ prove -e 'perl6 -I./lib' t/*
t/01-Basic.t .............. ok
…
All tests successful.

Test Summary Report
-------------------
t/03-lib-util.t         (Wstat: 0 Tests: 5 Failed: 0)
  TODO passed:   4-5
Files=22, Tests=788,  7 wallclock secs ( 0.07 usr  0.02 sys +  9.53 cusr  0.70 csys = 10.32 CPU)
Result: PASS
[sog@monica DBIish]$ perl6 -v
This is Rakudo version 2018.06-404-g0b3fc077e built on MoarVM version 2018.06-399-g4fc267b60
implementing Perl 6.c.

Seems that is required is now working.

Regards

@JJ
Copy link
Contributor

JJ commented Aug 11, 2018

I am a bit lost here, but the errors in CI do not seem to have anything to do with the previous PR (which passed).

@salortiz
Copy link
Contributor

Commit 33ada3e properly address the intent of this PR and the original issue #123

@salortiz salortiz closed this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants