Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document NQPMatchRole methods within Match. #2746

Closed
2 tasks
JJ opened this issue May 3, 2019 · 1 comment
Closed
2 tasks

Document NQPMatchRole methods within Match. #2746

JJ opened this issue May 3, 2019 · 1 comment
Labels
docs Documentation issue (primary issue type) new part of "docs" - indicates that this documentation is for a new, currently undoc'd section

Comments

@JJ
Copy link
Contributor

JJ commented May 3, 2019

The problem

Some methods Match takes from NQPMatchRole are documented. Some are not.

Suggestions

Check them out, document them. Start with those that are spec, continue (maybe) or mention (surely) those that are not.

While we're at it, maybe revise the rest of the methods to check for correctness in the definition.
@JJ JJ added docs Documentation issue (primary issue type) new part of "docs" - indicates that this documentation is for a new, currently undoc'd section labels May 3, 2019
@moritz
Copy link
Collaborator

moritz commented May 3, 2019

FTR I have found four instances of Match.make in the test suite, so I'd contest the "not tested explicitly" comment.

@moritz moritz closed this as completed in 0ab9021 May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation issue (primary issue type) new part of "docs" - indicates that this documentation is for a new, currently undoc'd section
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JJ @moritz