Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Classes Tutorial (classtut) documentation #979

Closed
payerle opened this issue Oct 20, 2016 · 4 comments
Closed

Error in Classes Tutorial (classtut) documentation #979

payerle opened this issue Oct 20, 2016 · 4 comments
Labels
docs Documentation issue (primary issue type)

Comments

@payerle
Copy link

payerle commented Oct 20, 2016

In classtut document (e.g. https://docs.perl6.org/language/classtut), I believe there is an error in the section re Introspection when describing the " ^methods" method.

In the example output, it shows methods for class Programmer (which seems to be consistent with rest of the example output).

But in explanatory text below the example, it refers to (incorrectly I believe) the Employee class, e.g.

The :local named argument limits the returned methods to those defined in the Employee class

There is another reference to Employee class in the following paragraph.

I am still transitioning from Perl5 to 6, but I believe the two references to Employee class should actually be Programmer class.

@AlexDaniel
Copy link
Member

Yea, indeed! Can you submit a pull request with the fixes? Here is the file.

@titsuki
Copy link
Member

titsuki commented Oct 22, 2016

@payerle
It seems that you have merged your pull request on the different repository.
After forking this repository, you can send a pull request by the following operations:

$ git clone git@github.com:payerle/doc.git
$ cd doc
$ git checkout master
$ git remote add upstream git@github.com:perl6/doc.git 
$ git fetch upstream
$ git merge upstream/master
$ git checkout -b payerle-patch-1
# Open classtut.pod6 and fix this issue !
$ git commit -am "Update classtut.pod6: text/example discrepancy in Introspection section/master"
$ git push origin payerle-patch-1
# Send a pull request with Github GUI

good luck !

@payerle
Copy link
Author

payerle commented Oct 25, 2016

OK, thanks for the more detailed instructions.

On Fri, 21 Oct 2016, Itsuki Toyota wrote:

@payerle
It seems that you have merged your pull request on the different repository.
After forking this repository, you can send a pull request by the following operations:

$ git checkout master
$ git remote add upstream git@github.com:perl6/doc.git
$ git fetch upstream
$ git merge upstream
$ git checkout -b payerle-patch-1

Open classtut.pod6 and fix this issue !

$ git commit -am "Update classtut.pod6: text/example discrepancy in Introspection section/master"
$ git push origin payerle-patch-1

Send a pull request with Github GUI Interface

good luck !

?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.[ASZO_7rvwy4VWsPls5fXNeo7NQ4pqCypks5q2Z7zgaJpZM4KcaWc.gif]

Tom Payerle
IT-ETI-EUS payerle@umd.edu
4254 Stadium Dr (301) 405-6135
University of Maryland
College Park, MD 20742-4111

@AlexDaniel AlexDaniel added the docs Documentation issue (primary issue type) label Dec 1, 2016
@Altai-man
Copy link
Member

It seems like a bit of misunderstanding here, since there are no PR for a week already.

With all thanks to @payerle for spotting and reporting the mistake, I'll do edit it in the main repository to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue (primary issue type)
Projects
None yet
Development

No branches or pull requests

4 participants