Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up "Separating statements by semicolons" #1479

Merged
merged 4 commits into from Sep 1, 2017

Conversation

molecules
Copy link
Contributor

Trying to address #1477

@AlexDaniel
Copy link
Member

Looks about right. 👍

@molecules
Copy link
Contributor Author

What is the difference between travis-ci/push and travis-ci/pr ? The config files for each were identical.

@zoffixznet
Copy link
Contributor

2 cents:

However, if a block is a postcircumfix operator (e.g. indexing of a hash)

A postcircumfix operator is not a block. It just uses the same curly braces.

@molecules
Copy link
Contributor Author

I'm not sure how else to explain it:

my %hash = '5' => 'A', '7' => 'B';

put %hash{
            { put 'inside hash index'; 1}() +
            4
        };
put %hash{ 28/4 };

# Outputs
# inside hash index
# A
# B

@zoffixznet
Copy link
Contributor

Perhaps explanation isn't needed? If the text talks about blocks it might just add more confusion to also start mentioning non-blocks.

Deleting to avoid confusion
@zoffixznet zoffixznet merged commit 2854b7d into master Sep 1, 2017
@zoffixznet zoffixznet deleted the molecules-patch-3 branch September 1, 2017 16:08
@zoffixznet
Copy link
Contributor

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants