Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p6doc build errors #2103

Merged
merged 1 commit into from Jul 8, 2018
Merged

Fix p6doc build errors #2103

merged 1 commit into from Jul 8, 2018

Conversation

Kaiepi
Copy link
Collaborator

@Kaiepi Kaiepi commented Jun 17, 2018

The problem

zef install p6doc fails after building.

Solution provided

After looking through zef's code, I found that it considers the build to have passed only if a truthy value is returned, so I made the build method return True.

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, not sure about that. If it does not build, it might be because there's some error somewhere. Always returning True might not be a good idea. It will kick the error down the road, and will eventually show up someplace else...

@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Jun 17, 2018

Would checking if all the files were copied over and returning True/False depending on whether or not it succeeded be a better idea?

@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Jun 17, 2018

Something like this

@zoffixznet
Copy link
Contributor

Can this be merged now?

@coke
Copy link
Collaborator

coke commented Jul 8, 2018

Looks good to me, addresses JJ's concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants