Supply fix #2390
Merged
Supply fix #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies what triggers &done and &quit callbacks to be called on a tap object.
Stop text running to long
JJ
approved these changes
Oct 18, 2018
JJ
requested changes
Oct 18, 2018
There was a problem hiding this comment.
There seems to be an error in the pod: https://travis-ci.org/perl6/doc/jobs/443165385 Can you please check and fix it?
|
Fixed pod error in modules.pod and merged here. Closing and opening to re-run tests. |
|
Please try and use git pull --rebase to avoid merge commits, if possible. |
|
Think this is the intermittent error now, so going to try closing and opening again to check.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Supply doc is wrong about
done#2161Solution provided
Clarifies when &done and &quit are called