Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example use of whenever should use a react block #2448

Merged
merged 2 commits into from Nov 5, 2018

Conversation

jmaslak
Copy link
Contributor

@jmaslak jmaslak commented Nov 5, 2018

The problem

whenever needs to be in a react block (looks like a 6.d feature).

Solution provided

Wrapped the usage of whenever in a react block within the example for listen().

Also added myself to CREDITS.

@zoffixznet
Copy link
Contributor

I sent you an invite to perl6 GitHub org that gives you access to most of our repos. You can accept it here: https://github.com/perl6/

Once you do, you will be able to merge this PR yourself and commit future work directly.

@jmaslak
Copy link
Contributor Author

jmaslak commented Nov 5, 2018

Thanks!

I'll merge this tomorrow assuming nobody comments that they have issues with it.

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are not using $big-finish any more, could that declaration be eliminated?

@jmaslak jmaslak merged commit f20a2a2 into Raku:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants