nativecall: Add language to address #2684 #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax for NativeCall callable signature constraints under Rakudo deviates from the usual syntax. There is an issue at rakudo/rakudo#2878 addressing this, but until this is addressed, some minimal explanation for the strange syntax is needed.
|
Please don’t merge this yet; it’s for discussion at #2684. |
JJ
requested changes
May 15, 2019
| @@ -653,9 +653,18 @@ say $esponja; | |||
|
|
|||
| NativeCall also supports native functions that take functions as arguments. One | |||
| example of this is using function pointers as callbacks in an event-driven | |||
| system. When binding these functions via NativeCall, one need only provide the | |||
| system. When binding these functions via NativeCall, one should need only provide the | |||
There was a problem hiding this comment.
need only provide is correct, should need only is not. should need to only provide could be an alternative.
There was a problem hiding this comment.
needs only provide, actually...
| equivalent signature as L<a constraint on the code parameter|/type/Signature#Constraining_signatures_of_Callables>: | ||
|
|
||
| # See below--this syntax does not work on Rakudo currently |
There was a problem hiding this comment.
I really see no point in including an example of something that does not work. We can mark an issue as "external" and wait for it to be solved instead.
| # void SetCallback(int (*callback)(const char *)) | ||
| my sub SetCallback(&callback:(Str --> int32)) is native('mylib') { * } | ||
|
|
||
| However, in the case of NativeCall, currently Rakudo requires a space between the |
There was a problem hiding this comment.
Again, this kind of statement is impossible to maintain. Currently when? Up to when? We can leave the issue open if needed, but the documentation should reflect what's happening right now.
JJ
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax for NativeCall callable signature constraints under Rakudo
deviates from the usual syntax. There is an issue at
rakudo/rakudo#2878 addressing this, but until this is addressed, some
minimal explanation for the strange syntax is needed.