Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio::Encode::LameMP3 #287

Closed
AlexDaniel opened this issue Aug 3, 2018 · 2 comments
Closed

Audio::Encode::LameMP3 #287

AlexDaniel opened this issue Aug 3, 2018 · 2 comments
Assignees
Labels
failing dependency This module depends on another module that is not installable native dependency Fails because it needs some library installed first

Comments

@AlexDaniel
Copy link
Member

AlexDaniel commented Aug 3, 2018

Module Audio::Encode::LameMP3 is failing its tests and/or does not install.

  • Please close this issue only if the module passes its tests and is installable. One way to test it is to run zef install MODULENAME.
  • If you can install the module without any problems, label this ticket with works for me and close the issue.
  • If it needs a native library, put native dependency label, describe what you did to install it and ensure that same instructions are present in the README file of the module (otherwise submit a pull request). If everything is green you can close the issue.
  • If the module is broken, try to fix it and send a PR. Add PR sent label and close the issue.
  • If there is a problem in one of the dependencies, add failing dependency label and write a comment explaining the situation. Leave this ticket open and feel free to work on the corresponding ticket for the failing dependency.
  • It is a good idea to assign yourself to this ticket if you're working on it (to make sure two or more people are not working on the same ticket at the same time).

If you can't self-assign, attach a label, or close the ticket, please let us know on #perl6 channel on freenode or just leave a comment here. We will try to give you privileges as fast as possible.

@Altai-man Altai-man self-assigned this Aug 3, 2018
@Altai-man Altai-man added failing dependency This module depends on another module that is not installable native dependency Fails because it needs some library installed first labels Aug 3, 2018
@Altai-man
Copy link
Member

Fail because of Audio::Taglib::Simple issues, plus toster is:

Won't build because no libmp3lame
You need to have libmp3lame installed

README has instructions on how to install native library: https://github.com/jonathanstowe/Audio-Encode-LameMP3#installation
Locally it installs fine.

@jonathanstowe
Copy link

Also it only uses the Audio::Taglib::Simple in the tests (to test that the tags are set,) it will infact work fine without this.

I'd go a PR with a working alternative if I don't get there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failing dependency This module depends on another module that is not installable native dependency Fails because it needs some library installed first
Projects
None yet
Development

No branches or pull requests

3 participants