Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::UserAgent #420

Closed
AlexDaniel opened this issue Feb 8, 2019 · 10 comments
Closed

HTTP::UserAgent #420

AlexDaniel opened this issue Feb 8, 2019 · 10 comments
Labels
fixed The module was fixed, waiting for it to be closed automatically

Comments

@AlexDaniel
Copy link
Member

Module HTTP::UserAgent cannot be installed (AlwaysFail), perhaps it has some failing tests.

  • Tickets are opened/closed in this repo automatically (though not immediately).
  • If you can install the module without any problems, add works for me label, leave a comment saying that it works for you and mention any details that you feel are important.
  • If it needs a native library, put native dependency label, describe what you did to install it and ensure that same instructions are present in the README file of the module (otherwise submit a pull request). Also try to update this wiki page.
  • If the module is broken, try to fix it and send a PR. Add PR sent label.
  • If there is a problem in one of the dependencies, add failing dependency label and write a comment explaining the situation. Feel free to work on the corresponding ticket for the failing dependency.
  • It is a good idea to assign yourself to this ticket if you're working on it (to make sure two or more people are not working on the same ticket at the same time).
  • Once you are done, search for a next ticket.

If you can't self-assign yourself or attach a label, please let us know on #perl6 channel on freenode or just leave a comment here. We will try to give you privileges as fast as possible.

Output:

===> Searching for: HTTP::UserAgent
===> Found: HTTP::UserAgent:ver<1.1.46>:auth<github:sergot> [via Zef::Repository::Ecosystems<p6c>]
===> Fetching [OK]: HTTP::UserAgent:ver<1.1.46>:auth<github:sergot> to /home/alex/Blin/data/zef-data/tmp/1549581438.8246.3516/http-useragent.git
===> Extraction [OK]: HTTP::UserAgent to /home/alex/Blin/data/zef-data/store/http-useragent.git
===> Testing: HTTP::UserAgent:ver<1.1.46>:auth<github:sergot>
t/001-meta.t ............... ok
t/010-headers.t ............ ok
t/020-message.t ............ ok
t/030-cookies.t ............ ok
t/040-request.t ............ ok
t/050-response.t ........... ok
t/060-ua-common.t .......... ok
t/070-ua-simple.t .......... ok
Failed to resolve host name 'filip.sergot.pl' with family 0. Error: 'Name or service not known'
  in method get-connection at /home/alex/Blin/data/zef-data/store/http-useragent.git/db754a0a6a7c0e0462d426a6f04cd628c040f2e2/lib/HTTP/UserAgent.pm6 (HTTP::UserAgent) line 373
  in method get-connection at /home/alex/Blin/data/zef-data/store/http-useragent.git/db754a0a6a7c0e0462d426a6f04cd628c040f2e2/lib/HTTP/UserAgent.pm6 (HTTP::UserAgent) line 359
  in method request at /home/alex/Blin/data/zef-data/store/http-useragent.git/db754a0a6a7c0e0462d426a6f04cd628c040f2e2/lib/HTTP/UserAgent.pm6 (HTTP::UserAgent) line 156
  in method get at /home/alex/Blin/data/zef-data/store/http-useragent.git/db754a0a6a7c0e0462d426a6f04cd628c040f2e2/lib/HTTP/UserAgent.pm6 (HTTP::UserAgent) line 102
  in method get at /home/alex/Blin/data/zef-data/store/http-useragent.git/db754a0a6a7c0e0462d426a6f04cd628c040f2e2/lib/HTTP/UserAgent.pm6 (HTTP::UserAgent) line 106
  in block <unit> at t/080-ua.t line 30

# Looks like you planned 10 tests, but ran 4
t/080-ua.t ................. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 6/10 subtests 
t/082-exceptions.t ......... ok
t/085-auth.t ............... ok
t/090-ua-ssl.t ............. ok
t/100-redirect-ssl.t ....... ok
t/110-redirect-cookies.t ... ok
t/150-issue-64.t ........... ok
t/160-issue-67.t ........... skipped: Need a new site to test with
t/170-request-common.t ..... ok
t/180-mediatype.t .......... ok
t/190-issue-116.t .......... ok
t/200-w3-test-encodings.t .. ok
t/210-content-encoding.t ... ok
t/220-binary-content.t ..... ok
t/230-binary-request.t ..... ok
t/250-issue-144.t .......... ok
t/260-no-proxy.t ........... ok
t/270-issue-212.t .......... ok

Test Summary Report
-------------------
t/080-ua.t               (Wstat: 65280 Tests: 4 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 4.
t/090-ua-ssl.t           (Wstat: 0 Tests: 2 Failed: 0)
  TODO passed:   1
Files=26, Tests=209, 91 wallclock secs ( 0.16 usr  0.04 sys + 70.86 cusr  3.49 csys = 74.55 CPU)
Result: FAIL
===> Testing [FAIL]: HTTP::UserAgent:ver<1.1.46>:auth<github:sergot>
Failed to get passing tests, but continuing with --force-test
===> Installing: HTTP::UserAgent:ver<1.1.46>:auth<github:sergot>
===> Install [OK] for HTTP::UserAgent:ver<1.1.46>:auth<github:sergot>

Ping @sergot

Previous ticket: #191

@jonathanstowe
Copy link

Test broken by real life. Will check when I get in.

@JJ
Copy link
Collaborator

JJ commented Feb 8, 2019

This is the module with the highest river score: https://github.com/JJ/p6-river/blob/master/data/river-scores.csv. Fixing it will automatically fix other dependencies. @jonathanstowe are you working on it?

@AlexDaniel
Copy link
Member Author

@JJ fwiw Blin is smart enough to force install failing modules so dependencies should not be affected too much.

@jonathanstowe
Copy link

I'm in a kind of todo the test until there's a better test host available, 😎 Also more mocking.

@JJ
Copy link
Collaborator

JJ commented Feb 8, 2019 via email

@jonathanstowe
Copy link

It's a fail in one of the "live" tests that should be skipped anyhow (assuming that NETWORK_TESTING wasn't applied,) Just looking anyhow.

@jonathanstowe
Copy link

WFM. Except if "NETWORK_TESTING" is set, wherein it fails exactly as above. I'm going to push a change that TODOs that test and put an issue such that more coverage can be achieved by mocking the network collection, otherwise it's always going to be whackamole against various disappearing network hosts.

jonathanstowe added a commit to sergot/http-useragent that referenced this issue Feb 8, 2019
This is to address the Raku/ecosystem-unbitrot#420

It appears that the host has become unresolvable.
@jonathanstowe
Copy link

That should be fixed by the 73bc30c . Maybe someone can take a more substantial look at it.

@jonathanstowe
Copy link

Okay that wasn't fixed by that commit but it was fixed by the next one. Someone wants to make all the testing tools behave the same.

@jonathanstowe
Copy link

This should be good now, if someone wants to check and close https://travis-ci.org/sergot/http-useragent

@jonathanstowe jonathanstowe added the fixed The module was fixed, waiting for it to be closed automatically label Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed The module was fixed, waiting for it to be closed automatically
Projects
None yet
Development

No branches or pull requests

3 participants