Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal::Print #526

Closed
AlexDaniel opened this issue Feb 8, 2019 · 9 comments
Closed

Terminal::Print #526

AlexDaniel opened this issue Feb 8, 2019 · 9 comments
Assignees
Labels
issue sent Posted a previously unreported issue with the original author to investigate PR sent Sent a pull review to the issue

Comments

@AlexDaniel
Copy link
Member

Module Terminal::Print cannot be installed (AlwaysFail), perhaps it has some failing tests.

  • Tickets are opened/closed in this repo automatically (though not immediately).
  • If you can install the module without any problems, add works for me label, leave a comment saying that it works for you and mention any details that you feel are important.
  • If it needs a native library, put native dependency label, describe what you did to install it and ensure that same instructions are present in the README file of the module (otherwise submit a pull request). Also try to update this wiki page.
  • If the module is broken, try to fix it and send a PR. Add PR sent label.
  • If there is a problem in one of the dependencies, add failing dependency label and write a comment explaining the situation. Feel free to work on the corresponding ticket for the failing dependency.
  • It is a good idea to assign yourself to this ticket if you're working on it (to make sure two or more people are not working on the same ticket at the same time).
  • Once you are done, search for a next ticket.

If you can't self-assign yourself or attach a label, please let us know on #perl6 channel on freenode or just leave a comment here. We will try to give you privileges as fast as possible.

Output:

===> Searching for: Terminal::Print
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
===> Found: Terminal::Print:ver<0.94> [via Zef::Repository::Ecosystems<p6c>]
===> Fetching [OK]: Terminal::Print:ver<0.94> to /home/alex/Blin/data/zef-data/tmp/1549582418.32671.9895/Terminal-Print.git
===> Extraction [OK]: Terminal::Print to /home/alex/Blin/data/zef-data/store/Terminal-Print.git
===> Testing: Terminal::Print:ver<0.94>
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "screen.xterm-256color"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
tput: unknown terminal "tmux-256color"
===SORRY!===
Please update @valid-terminals with your desired TERM ('rxvt', is it?) and submit a PR if it works
t/00-basics.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
No subtests run 
===SORRY!===
Please update @valid-terminals with your desired TERM ('rxvt', is it?) and submit a PR if it works
t/10-grid.t .... 
Dubious, test returned 1 (wstat 256, 0x100)
No subtests run 
===SORRY!===
Please update @valid-terminals with your desired TERM ('rxvt', is it?) and submit a PR if it works
t/11-golf.t .... 
Dubious, test returned 1 (wstat 256, 0x100)
No subtests run 

Test Summary Report
-------------------
t/00-basics.t (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/10-grid.t  (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
t/11-golf.t  (Wstat: 256 Tests: 0 Failed: 0)
  Non-zero exit status: 1
  Parse errors: No plan found in TAP output
Files=3, Tests=0, 17 wallclock secs ( 0.03 usr  0.00 sys + 10.76 cusr  1.60 csys = 12.39 CPU)
Result: FAIL
===> Testing [FAIL]: Terminal::Print:ver<0.94>
Failed to get passing tests, but continuing with --force-test
===> Installing: Terminal::Print:ver<0.94>
===> Install [FAIL] for Terminal::Print:ver<0.94>: ===SORRY!===
Please update @valid-terminals with your desired TERM ('rxvt', is it?) and submit a PR if it works

===SORRY!===
Please update @valid-terminals with your desired TERM ('rxvt', is it?) and submit a PR if it works


Ping @ab5tract

@JJ JJ self-assigned this Feb 8, 2019
@JJ
Copy link
Collaborator

JJ commented Feb 8, 2019

I don't know if it's worth the while to fix this. It's got 3 PRs sent, and no changes for 7 months.

@JJ JJ mentioned this issue Feb 9, 2019
Closed
@JJ
Copy link
Collaborator

JJ commented Feb 9, 2019

I have forked it and released it to the ecosystem with a bumped up version. jmp works now with the new version, after it's installed: #551

@JJ JJ added the PR sent Sent a pull review to the issue label Feb 9, 2019
@JJ JJ added the issue sent Posted a previously unreported issue with the original author to investigate label Feb 9, 2019
@AlexDaniel
Copy link
Member Author

I'm looking here:
https://github.com/JJ/Terminal-Print/blob/f35f679e403e794250d46b273da2ab2d9a417930/lib/Terminal/Print/Commands.pm6#L27

Is there any reason why it has to run something in shell?

@JJ
Copy link
Collaborator

JJ commented Feb 9, 2019 via email

@AlexDaniel
Copy link
Member Author

yes but can't you use tput with run?

@JJ
Copy link
Collaborator

JJ commented Feb 9, 2019

Ah, I see what you mean. Let me try that.

@jonathanstowe
Copy link

could it be made to use the termios module with hard coded capability values (assuming they are fairly common capabilities?)

@jonathanstowe
Copy link

Or help me make Term::Cap useable :-)

@JJ
Copy link
Collaborator

JJ commented Feb 9, 2019

I don't think that's trivial, but once we have forked it, I guess we could as well do that.
Anyway, the new version fixes the particular issues raised here, just a matter of adding stuff to the whitelist. Mid-term roadmap could go there, but who knows.

@AlexDaniel AlexDaniel mentioned this issue Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue sent Posted a previously unreported issue with the original author to investigate PR sent Sent a pull review to the issue
Projects
None yet
Development

No branches or pull requests

3 participants