Skip to content

Commit

Permalink
[js] Check for the latest node.js
Browse files Browse the repository at this point in the history
  • Loading branch information
pmurias committed Oct 12, 2018
1 parent 7f60186 commit 6cf2cd9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions Configure.pl
Expand Up @@ -211,6 +211,13 @@
sorry($options{'ignore-errors'}, "You don't have node.js. Please install node.js.");
}

my $node_version = `node --version`;
my ($major, $minor, $path) = $node_version =~ /v(\d+)\.(\d+)\.(\d+)/;

This comment has been minimized.

Copy link
@MasterDuke17

MasterDuke17 Oct 12, 2018

Contributor

Missing indentation?

unless ($major > 10 || $major == 10 && $minor >= 10) {
chomp($node_version);
sorry($options{'ignore-errors'}, "Need at least node.js v10.10.0 (got $node_version)");
}

fill_template_file(
'gen/js/Makefile-JS.in',
$MAKEFILE,
Expand Down
2 changes: 1 addition & 1 deletion README.pod
Expand Up @@ -105,7 +105,7 @@ scratch.
=head2 JavaScript backend

The best thing before playing with it/hacking on it is to contact pmurias via IRC at #perl6 on irc.freenode.org.
It's recommended that you use node 10.5.0 as it's the version of node.js the JavaScript backend is developed with.
We depend on node.js at least 10.10.0

Building the JavaScript backend currently requires building the moar backend:

Expand Down

0 comments on commit 6cf2cd9

Please sign in to comment.