Optimize a loop in MATCH

- don't box strings - don't make variables we don't need
Raku · Apr 7, 2018 · 9b75f67 · 9b75f67
1 parent 17382e6
commit 9b75f67
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/QRegex/Cursor.nqp b/src/QRegex/Cursor.nqp
@@ -1184,11 +1184,9 @@ class NQPMatch is NQPCapture does NQPMatchRole {
                     $dest := nqp::atkey($hash, $onlyname);
                 }
                 while $csi < $cselems {
-                    my $subcur   := nqp::atpos($cs, $csi);
-                    my str $name := nqp::getattr_s($subcur, $?CLASS, '$!name');
-                    if !nqp::isnull_s($name) && nqp::defined($name) {
-                        my $submatch := $subcur.MATCH();
-                        nqp::push($dest, $submatch);
+                    my $subcur := nqp::atpos($cs, $csi);
+                    unless nqp::isnull_s(nqp::getattr_s($subcur, $?CLASS, '$!name')) {
+                        nqp::push($dest,$subcur.MATCH());
                     }
                     ++$csi;
                 }