Skip to content

Commit

Permalink
[js] Disable attribute hints till they are fixed to work with multi-i…
Browse files Browse the repository at this point in the history
…nheritance
  • Loading branch information
pmurias committed Jan 7, 2018
1 parent 2666a65 commit b6be545
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
3 changes: 2 additions & 1 deletion src/vm/js/Compiler.nqp
Expand Up @@ -1973,7 +1973,8 @@ class QAST::CompilerJS does DWIMYNameMangling does SerializeOnce {
# Get lookup hint if possible.
my int $hint := -1;
if $var[1].has_compile_time_value {
$hint := nqp::hintfor($var[1].compile_time_value, $var.name);
#disabled till we handle hints with multi-inheritance correctly
#$hint := nqp::hintfor($var[1].compile_time_value, $var.name);
}

my $suffix := self.suffix_from_type($type);
Expand Down
8 changes: 5 additions & 3 deletions src/vm/js/Operations.nqp
Expand Up @@ -286,9 +286,11 @@ class QAST::OperationsJS {

my sub static_hint($node) {
my int $hint := -1;
if $node[1].has_compile_time_value && nqp::istype($node[2], QAST::SVal) {
$hint := nqp::hintfor($node[1].compile_time_value, $node[2].value);
}

# disabled till we handle hints with multi-inheritance correctly
#if $node[1].has_compile_time_value && nqp::istype($node[2], QAST::SVal) {
# $hint := nqp::hintfor($node[1].compile_time_value, $node[2].value);
#}

$hint != -1 ?? $hint !! NQPMu;
}
Expand Down

0 comments on commit b6be545

Please sign in to comment.