Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme outdated, still says JDK8 when JDK9 is required #571

Closed
kentfredric opened this issue Aug 7, 2019 · 8 comments
Closed

Readme outdated, still says JDK8 when JDK9 is required #571

kentfredric opened this issue Aug 7, 2019 · 8 comments

Comments

@kentfredric
Copy link
Contributor

As of: a81c05f

https://github.com/perl6/nqp/blob/a81c05f488a6ee3848e6c1ca63fd496693fb5105/tools/templates/jvm/Makefile.in#L132-L134

And especially due to: 104a5ce

https://github.com/perl6/nqp/blob/104a5ce4d4eeaf42aeb62355b7a5124f18965187/tools/templates/jvm/Makefile.in#L132-L134

Surely, the minimum is JDK9/1.9, not JDK8/1.8 as stated in README.pod:

https://github.com/perl6/nqp/blob/cd588c17dabd9732ca70ab05e9a2ae153e66f29e/README.pod#L35-L39

Especially as the "--release 9" parameter is completely not understood by JDK8.

javac: invalid flag: --release
@AlexDaniel
Copy link
Member

Can you submit a PR to update it?

@AlexDaniel
Copy link
Member

Or just update it directly. Invitation sent, you can accept it on this page https://github.com/perl6

@kentfredric
Copy link
Contributor Author

Honestly I'd rather it was possible to keep supporting JDK8, given vendor side, we can't actually use anything newer yet. Confirming that using JDK9 is an inescapable reality is step 1 for getting this documentation changed IME.

@AlexDaniel
Copy link
Member

@kentfredric what about using rakudo 2019.03.1? The requirement was bumped in and 2019.07 2019.07.1 only. 2019.03.1 is also a great release.

@kentfredric
Copy link
Contributor Author

Currently my plan is to make 2019.07* available only using moarvm, and only support any/all jvm/moar for 2019.03.* and lower, at least until we can get a newer JDK in tree.

It just means our ability to provide fully-fledged and recent editions of things are hampered by the minimum JDK requirement, and end-users will not be able to use 2019.07.1 with the JVM backend at all, so users wanting a JVM backend will be stuck with 2019.03.1

This isn't exactly a great situation, but I'm not in any position to do anything else about it ( Because getting newer JDK is much beyond the scope of things I can do, and requires vendor-wide action )

pvdabeel pushed a commit to pvdabeel/gentoo that referenced this issue Aug 7, 2019
Note that this ebuild currently is unusable as:

1. Using moar w/ moar-9999 currently has an odd problem where it needs
   to use a non-existent "ffi.h"

2. Using jvm currently is unsupportable as upstream currently requires
   jdk-1.9/9, which we presently don't have any support for in Gentoo.

Hopefully these issues won't be present when I use this ebuild as a
base for the most recently shipped nqp release.

See also: Raku/nqp#571

Package-Manager: Portage-2.3.66, Repoman-2.3.16
Signed-off-by: Kent Fredric <kentnl@gentoo.org>
@kentfredric
Copy link
Contributor Author

Or just update it directly. Invitation sent, you can accept it on this page https://github.com/perl6

Invite accepted, however:

  • ERROR: Permission to perl6/nqp.git denied to kentfredric

Do I still need to do a PR :) ?

@AlexDaniel
Copy link
Member

Fixed! Sorry!

@kentfredric
Copy link
Contributor Author

Done, and thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants