Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nqp for recent kill-useless-defaults merge in parrot #24

Merged
merged 3 commits into from Oct 1, 2011

Conversation

plobsing
Copy link
Contributor

The get_addr op no longer returns the address of objects that don't implement the get_pointer() vtable. A new op, get_id, has been implemented to handle nqp's use case.

Such instances of get_addr have been replaced by get_id.

An alternative to the provided patch might be to use Hashes with the key type 'Hash_key_type_PMC_ptr', which would avoid the need to mangle keys manually.

@moritz
Copy link
Contributor

moritz commented Sep 21, 2011

Thanks for your patches, I've applied them to the new 'kill-useless-defaults' nqp branch, and bumped PARROT_REVISION in that branch.

I don't want to merge this into nqp/master until after the Rakudo release this month.

@moritz
Copy link
Contributor

moritz commented Sep 21, 2011

Contrary to what I wrote in the beginning (where I accidentally used an older copy of rakudo), rakudo builds fine on this branch, and passes all spectests.

@tadzik tadzik merged commit c846f63 into Raku:master Oct 1, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants