[moar] Use nqp::indexic op in QASTRegexCompilier #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only remaining places in QASTRegexCompilier for MVM are used for character ranges, which need to stay lc and uc to make character ranges make sense. This takes advantage of the MoarVM case insensitive string index operator, giving us at least 1.8x speed boost doing case insensitive regex.
samcv
changed the title
|
Merging :-) @zoffixznet++ for reminding me of the PR before our release. Would have been a shame if the case insensitive regex improvements were not included in the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining places in QASTRegexCompilier for MVM are used for
character ranges, which need to stay lc and uc to make character ranges
make sense.
This takes advantage of the MoarVM case insensitive string index operator,
giving us at least 1.8x speed boost doing case insensitive regex.