Fix op_if/unless/with/without coercion #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample code: ``` my $foo := 42; my int $bar := $foo || 200; say($bar); ``` Before it says '0' and now '42'. The problem is we generate $foo || 200 as - QAST::Op(unless &infix:<||>) || - QAST::Var(lexical $bar) - QAST::IVal(200) and thus $bar only be a condition. If we want to return its value, we forget to coerce its kind. Now this fix only apply on op_unless. If applies on the four ops handled this block, it fails some tests in t/qast/01-qast.t.
|
No, this break to say 0. I will work on it. |
tisonkun
changed the title
tisonkun
changed the title
|
Now we generate correct condition IR, it's quite like a copy from JVM backend. |
pmurias
requested changes
Dec 7, 2017
| (nqp::defined($*WANT) ?? $*WANT !! $MVM_reg_obj)); | ||
| $fix_coercion := $coercion; | ||
| $regalloc.release_register($res_reg, $res_kind); | ||
| $res_reg := $regalloc.fresh_register($coercion.result_kind); |
There was a problem hiding this comment.
You need to set the register in $res_reg at runtime instead of overwriting $res_reg at compile time. We might succeed and not do the coercion at all
| ); | ||
| } | ||
|
|
||
| my $fix_coercion; |
There was a problem hiding this comment.
No need for a variable, just add the coercion when we are checking for the 3 operand form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample code:
Before it says '0' and now '42'.
The problem is we generate $foo || 200 as
and thus $bar only be a condition. If we want to return its value,
we forget to coerce its kind.
Now this fix only apply on op_unless. If applies on the four ops
handled this block, it fails some tests in t/qast/01-qast.t.
For details