[jvm] Look inside containers for parametric type #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some spectests (cmp. RT #132673).
|
I'm not sure if this patch make sense -- but it seems to fix some roast issues on the JVM backend. |
|
I think |
As jnthn++ pointed out, decont itself does the check of whether it needs to decont the passed object.
|
Of course, you are right. I didn't realize that decont is a noop if it gets a decontainerized argument. Thanks, jnthn! If the addition of decont makes sense otherwise, I could as well push that change directely (avoiding the intermediate and the merge commit). |
|
Yes, it makes sense to me. |
|
I commited the patch as f6bccf7 and I'm closing this PR. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some spectests (cmp. RT #132673).