Post release #399
Merged
Post release #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of new .annotate_self
Fixes RT#132718: https://rt.perl.org/Ticket/Display.html?id=132718 When we put together the MAST for if/unless/while/until/repeat_while /repeat_until ops, we look up which MVM conditional op to use. The compiler did not know about non-fullwidth natives, and complained about that with a crash. Fix by teaching it about all the types and coercing non-fullwidth natives to fullwidth when calling the op. - Use array lookup instead of nested ternaries; measurement showed this approach to be 3x faster - Remove duplicate sub and move All The Things to the Regex compiler. the Operations still sees our arrays, so there's no duplication involved - Swapping if_s0 to if_s op is OK: the if_s0 variant used to treat "0" string as false, but was later changed to treat it as true and after expansion of all the macros is now exactly equivalent to plain if_s. Same with unless_s0 - I applied the lookup of extra types in one place in the Regex compiler that used to use the old lookup. However, I did not add coercion as I'm unsure what code exercises that codepath and whether the coercion is needed at all.
Per explanation at https://irclog.perlgeek.de/moarvm/2018-01-21#i_15717659
Addresses some cases in rakudo/rakudo#1416 getlexref is expensive compared to plain getlex, so if we know we're not gonna use the conditional, try coercing it to a simpler value. This gets rid of lexref and if we got native-type value, goes to use the native if_/unless_ op. The perf improvement applies only nqp::if/nqp::unless/nqp::with/ nqp::without when the conditional is a variable and the conditional is not used for anything other than deciding the branch. I would assume other cases would've be optimizeable, but I kept getting confusing crashes during nqp compilation when I tried.
We already know we'll need _o because we test the op's kind on
entry to the branch, so just use those without lookup. No idea
why they're reversed ("if" takes an "unless_o"), but that was the
case before I touched this part of the codebase.
…when looking through QAST dumps.
- Teach QAST::Node.dump to dump value for statement_id
- Teach QAST::WVal.dump_extra_node_info to rake for CUID
from past_block annotation, if one's present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.