Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new test file for nqp using perl #400

Closed
wants to merge 1 commit into from

Conversation

tbrowder
Copy link
Member

  • provides a test harness for testing known failures
  • test for known failure using =cut

+ provides a test harness for testing known failures
+ test for known failure using =cut
@zoffixznet
Copy link
Contributor

xt/ is generally for author tests while t/ is for user tests. This PR seems to be adding POD tests as author tests (is that necessary?) while at the same time it's adding author tests to be run with make test, along side user tests.

@tbrowder
Copy link
Member Author

The test should be standard, but they use perl 5 so they need to be in a separate dir from the “exec nqp” tests. I forgot the special convention for xt, how about some other, unique dir then like “t/perl5/”?

@zoffixznet
Copy link
Contributor

zoffixznet commented Jan 25, 2018

Personally, I'd just write the nqp version of STDERR capturing routine instead of writing an entire test file in Perl 5 just to execute a program that creates a file.

There is even already an implementation that can be adapted

@tbrowder
Copy link
Member Author

I’ll close this and resubmit after we decide where to put the Perl 5 tests for .

@tbrowder tbrowder closed this Jan 25, 2018
@tbrowder tbrowder deleted the add-nqp-pod-tests branch February 25, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants