Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename IO sub "spew" to "spurt" #417

Merged
merged 1 commit into from Feb 21, 2018
Merged

rename IO sub "spew" to "spurt" #417

merged 1 commit into from Feb 21, 2018

Conversation

tbrowder
Copy link
Member

changes to file "src/core/IO.nqp":

  • rename sub "spew" to "spurt" for consistency with
    the rest of Perl

changes to file "t/nqp/019-file-ops.t":

  • add tests for sub "spurt"

changes to file "docs/built-ins.md":

  • change "spew" to "spurt" in subs
  • add "get" to the documented methods on a file handle
  • remove full documentation on the slurp method
    on a file handle (but add it the the list
    of available file handle methods)

changes to file "src/core/IO.nqp":
+ rename sub "spew" to "spurt" for consistency with
  the rest of Perl

changes to file "t/nqp/019-file-ops.t":
+ add tests for sub "spurt"

changes to file "docs/built-ins.md":
+ change "spew" to "spurt" in subs
+ add "get" to the documented methods on a file handle
+ remove full documentation on the slurp method
  on a file handle (but add it the the list
  of available file handle methods)
@tbrowder
Copy link
Member Author

I did check all nqp source and test files, as well as all the Perl 6 and nqp source and test
files in the rakudo repo and roast repo to ensure that “spew” isn’t being used.

@AlexDaniel
Copy link
Member

I don't mind this change at all, although I wonder why it was called spew in the first place.

@jnthn
Copy link
Contributor

jnthn commented Feb 21, 2018

@AlexDaniel Because it was added before the decision to name this functionality spurt in Perl 6.

👍 on aligning the NQP sub's name with the Perl 6 one.

@jnthn jnthn merged commit cb4297b into Raku:master Feb 21, 2018
@tbrowder tbrowder deleted the spew2spurt branch February 25, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants