unfudge test, co #274 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcv
reviewed
Jul 20, 2018
t/nqp/019-file-ops.t
Outdated
| @@ -1,4 +1,4 @@ | |||
| #! nqp | |||
| #!/usr/bin/env nqp | |||
There was a problem hiding this comment.
We may as well remove this line. Since not even all the test files have a shebang line. (Also the files don't have the execute bit either).
There was a problem hiding this comment.
done.
I'll appreciate it if you can test this change on a macOS, IIRC the last time @coke uncomment this test, it causes regression. that's why i don't merge this pr yet.
|
A small nit: "Update $somefile" is not an ideal commit message -- the file name being edited is already part of the commit history, so declaring it has been updated is redundant. |
|
@ugexe thanks! I will do a "squash and merge" rather than directly merge with every commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test pass on my own macOS.
I try to look back the cases that it fails, but surprisingly those did not complain about 019-file-ops.t
strange.