Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix async socket ops on the JVM #510

Closed
wants to merge 1 commit into from

Conversation

Kaiepi
Copy link
Contributor

@Kaiepi Kaiepi commented Oct 22, 2018

I forgot to update the bootstrap files in the original commit and
crucial parts of src/vm/jvm/runtime/org/perl6/nqp/runtime/IOOps.java
were reverted. This allows IO::Socket::Async .listen and .connect to
work on a basic level, but t/05-messages/02-errors.t in Rakudo fails
with a stack overflow.

@Kaiepi Kaiepi changed the title Partially fix async socket ops on the JVM [WIP] Fix async socket ops on the JVM Oct 22, 2018
I forgot to update the bootstrap files in the original commit and
crucial parts of src/vm/jvm/runtime/org/perl6/nqp/runtime/IOOps.java
were reverted. This allows IO::Socket::Async .listen and .connect to
work on a basic level, but t/05-messages/02-errors.t in Rakudo fails
with a stack overflow.
@Kaiepi
Copy link
Contributor Author

Kaiepi commented Oct 23, 2018

make spectest seems to run fine with these changes. Maybe there's a better way to write that one test that fails in particular?

@Kaiepi
Copy link
Contributor Author

Kaiepi commented Nov 4, 2018

Closing since the fix I'm working on now is unrelated to the code from here.

@Kaiepi Kaiepi closed this Nov 4, 2018
@Kaiepi Kaiepi deleted the async-socket branch November 4, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant