Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support build when moar's prefix ne target prefix #543

Closed
wants to merge 1 commit into from

Conversation

kazcw
Copy link

@kazcw kazcw commented May 24, 2019

Add a new config option, --with-moar-root=$DIR. This is necessary
to be able to build moar and nqp as separate NixOS packages.

Add a new config option, --with-moar-root=$DIR. This makes it possible
to build moar and nqp as separate NixOS packages.
@kazcw
Copy link
Author

kazcw commented May 24, 2019

This is not sufficient. On unix install-moar-runner.pl still assumes moar and nqp are installed to the same directory.

@kazcw
Copy link
Author

kazcw commented May 24, 2019

I think it'll be simpler to apply nix-specific patches than add the necessary knobs.

@kazcw kazcw closed this May 24, 2019
@kazcw kazcw deleted the with-moar-root branch May 24, 2019 06:30
@niner
Copy link
Contributor

niner commented May 24, 2019

But rakudo has supported different prefixes for MoarVM, NQP and rakudo for years via the --with-moar and --with-nqp options respectively?

@kazcw
Copy link
Author

kazcw commented May 24, 2019

@niner I'm trying to create separate packages for moar and nqp (and later rakudo), so I can't make use of any rakudo options to get nqp to build. nqp has its own with-moar option, but that only sets the path to the moar binary, not the support files that go with it, which is what this PR was in reference to. What I ended up doing is adding a patch like this to enable configuring the location of the whole moar installation, and another patch to set $relocatable = 0 in install-moar-runner.pl, and I now have nqp successfully building against a moar in another directory.

@niner
Copy link
Contributor

niner commented May 24, 2019

I've filed issues for both nqp and rakudo. This is clearly a regression that needs fixing before the next release.

@vrurg
Copy link
Contributor

vrurg commented May 24, 2019

@kazcw From you mentioning install-moar-runner.pl I conclude that you're not working on master. The script is gone already.

@kazcw
Copy link
Author

kazcw commented May 24, 2019

@vrurg I'm confused. I'm running de6e46c, which is currently the head of the branch called "master" in this repo. There's a file tools/build/install-moar-runner.pl: https://github.com/perl6/nqp/blob/master/tools/build/install-moar-runner.pl. It seems to be actively used, because by modifying it I can change the nqp and nqp-m scripts that get generated. Am I on the wrong master somehow?

@vrurg
Copy link
Contributor

vrurg commented May 26, 2019

@kazcw That's my oops, I apologize for the confusion. While actively switching between nqp and rakudo builds I mixed them up and was speaking about rakudo at that moment.

@kazcw
Copy link
Author

kazcw commented May 26, 2019

Oh that makes sense. I thought it seemed like we were talking about two different repos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants