Change associativity of exponentiation to 'right' #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associativity of the %exponentiation infix spec in NQP::Grammar was 'left' which does not match usual convention in mathematics and the associativity of ** in Perl 6. This commit changes it to 'right'.
The exponentiation operator was not exercised before.
|
That looks good to me--good catch! You should be able to merge it yourself. Thanks! |
|
Ok, just to be extra, extra sure I built rakudo and ran its test suite and the spectest with these patches applied to the backing nqp. Really doesn't seem to break anything. |
|
@tbrowder : No, apparently I have no write permissions to nqp, so I can't merge it myself. |
|
I'm sure that no one has ever tried using two or more exponentiation operators in NQP. |
|
And finally we know why :-) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled on this:
https://github.com/perl6/nqp/blob/7cccdb13e28b2aea7321bdef02408f842183d477/src/NQP/Grammar.nqp#L747
Exponentiation should be right-associative (like it is in Perl 6), no? The test suite passed before and passes after this PR, so I am not sure if this will have fall-out downstream. The second commit adds tests for the
**operator which hasn't been exercised at all.Maybe this is an instance of "if it's not (too) broken, don't fix it"?