Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure total timeout is less than ping timeout or parallelize bots #27

Open
MasterDuke17 opened this issue Sep 1, 2016 · 2 comments
Open

Make sure total timeout is less than ping timeout or parallelize bots #27

MasterDuke17 opened this issue Sep 1, 2016 · 2 comments
Labels
testneeded Issue is generally resolved but tests were not written yet

Comments

@MasterDuke17
Copy link
Collaborator

According to http://irclog.perlgeek.de/perl6/2016-08-30#i_13119980, if a bot is working for more than ~250 seconds it could get disconnected from a channel. We need to make sure that bots will stop any work before they hit the ping timeout, or parallelize them so they can respond to pings while still doing real work.
@AlexDaniel
Copy link
Member

So which bots are affected currently?

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
AlexDaniel added a commit that referenced this issue Oct 15, 2017
@AlexDaniel
Markdownify quotable output
cd8c07b 
Issue #152. Also, the script used to fetch IRC logs is now finally
committed.

Now it also processes every channel in parallel, so it is a little bit
faster. That said, the grep itself became slower because of the extra
code in it. Overall there's almost no change in speed.

Related: issue #27
@AlexDaniel
Copy link
Member

Also, another option is to return a Promise from irc-to-me, this way they won't ping out (but still a user should not have to wait for that long…).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testneeded Issue is generally resolved but tests were not written yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexDaniel @MasterDuke17