Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicodable and Statisfiable are leaking memory #80

Closed
AlexDaniel opened this issue Dec 15, 2016 · 5 comments
Closed

Unicodable and Statisfiable are leaking memory #80

AlexDaniel opened this issue Dec 15, 2016 · 5 comments
Labels
statisfiable Issues related to Statisfiable bot testneeded Issue is generally resolved but tests were not written yet unicodable Issues related to Unicodable bot

Comments

@AlexDaniel
Copy link
Member

Have no idea why yet.
@AlexDaniel AlexDaniel added the unicodable Issues related to Unicodable bot label Dec 15, 2016
@AlexDaniel
Copy link
Member Author

And Statisfiable is even worse.

@AlexDaniel AlexDaniel added the statisfiable Issues related to Statisfiable bot label Dec 16, 2016
@AlexDaniel AlexDaniel changed the title Unicodable is leaking memory Unicodable and Statisfiable are leaking memory Dec 16, 2016
@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel
Copy link
Member Author

Perhaps related to RT #130494

@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
@AlexDaniel
Copy link
Member Author

This was possibly due to timo/json_fast#21. I don't think I've seen this behavior lately.

@AlexDaniel
Copy link
Member Author

Is it possible to add a test for this? Hmmm…

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Apr 7, 2017
@AlexDaniel
Copy link
Member Author

Actually, we now track maxrss at the end of each test file: c6aa350 (@MasterDuke17++). This does not exactly work as a test, but it allows us to track changes to memory usage over time. Also, nobody is keeping an eye on this currently, but everything to make it easy is in place. I think this is closable.

@AlexDaniel AlexDaniel mentioned this issue Jun 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
statisfiable Issues related to Statisfiable bot testneeded Issue is generally resolved but tests were not written yet unicodable Issues related to Unicodable bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel